24 Feb

Hackers May Already Be Targeting This Authenticated Persistent XSS Vulnerability in IMPress for IDX Broker

As part of monitoring we do to make sure we are providing customers of our service with the best possible data on vulnerabilities in WordPress plugins they may be using we monitor for what look to be hackers probing for usage of plugins to make sure we quickly can warn our customers of unfixed vulnerabilities that hackers are likely targeting. There was probing on our website today for the plugin IMPress for IDX Broker by requesting these files:

  • /wp-content/plugins/idx-broker-platinum/readme.txt
  • /wp-content/plugins/idx-broker-platinum/assets/js/idx-leads.js
  • /wp-content/plugins/idx-broker-platinum/assets/css/idx-admin.css

When we started reviewing the plugin we immediately found a vulnerability that matches the type we have have seen in plugins being probed for in a similar way in the past, an authenticated persistent cross-site scripting (XSS) vulnerability.

The issue starts with the plugin registering the function idx_refreshapi() to be accessible through WordPress’ AJAX functionality to those logged in to WordPress:

33
add_action( 'wp_ajax_idx_refresh_api', array( $this, 'idx_refreshapi' ) );

That function will save a new value for the WordPress option “idx_broker_apikey”:

256
257
258
259
public function idx_refreshapi() {
	$this->idx_api->clear_wrapper_cache();
	$this->idx_api->idx_clean_transients();
	update_option( 'idx_broker_apikey', $_REQUEST['idx_broker_apikey'], false );

The code lacks a capabilities checks to limit access to changing the option to the users intended to be able to do it, a nonce check to prevent cross-site request forgery (CSRF), and sanitization of new value.

As the proof of concept below shows there isn’t escaping when the value is output on at least one admin page, so all together you have an authenticated persistent XSS vulnerability.

Due to the lack of a nonce check this could also be exploited through CSRF.

WordPress Causes Full Disclosure

Due to the moderators of the WordPress Support Forum’s continued inappropriate behavior we are full disclosing vulnerabilities in protest until WordPress gets that situation cleaned up, so we are releasing this post and then leaving a message about that for the developer through the WordPress Support Forum. You can notify the developer of this issue on the forum as well. Hopefully the moderators will finally see the light and clean up their act soon, so these full disclosures will no longer be needed (we hope they end soon). You would think they would have already done that, but considering that they believe that having plugins, which have millions installs, remain in the Plugin Directory despite them knowing they are vulnerable is “appropriate action”, something is very amiss with them (which is even more reason the moderation needs to be cleaned up).

Update: To clear up the confusion where developers claim we hadn’t tried to notify them through the Support Forum (while at the same time moderators are complaining about us doing just that), here is the message we left for this vulnerability:

Is It Fixed?

If you are reading this post down the road the best way to find out if this vulnerability or other WordPress plugin vulnerabilities in plugins you use have been fixed is to sign up for our service, since what we uniquely do when it comes to that type of data is to test to see if vulnerabilities have really been fixed. Relying on the developer’s information, can lead you astray, as we often find that they believe they have fixed vulnerabilities, but have failed to do that.

Proof of Concept

The following proof concept will cause an alert box with any available cookies to be shown when visiting the page /wp-admin/admin.php?page=idx-broker, when logged in to WordPress.

Make sure to replace “[path to WordPress]” with the location of WordPress.

http://[path to WordPress]/wp-admin/admin-ajax.php?action=idx_refresh_api&idx_broker_apikey="><script>alert(document.cookie);</script>

Concerned About The Security of the Plugins You Use?

When you are a paying customer of our service you can suggest/vote for the plugins you use to receive a security review from us. You can start using the service for free when you sign up now.